[kmail2] [Bug 415254] [regression] HTML viewer complains about "external references to images etc." when there are no images

[Thiago Macieira]

https://bugs.kde.org/show_bug.cgi?id=415254

--- Comment #3 from Thiago Macieira <thiago at kde.org> ---
(In reply to Laurent Montel from comment #2)
> Git commit 56f1d42f68ed2f597fc599e4952ee81e579cd355 by Laurent Montel.
> Committed on 17/12/2019 at 06:05.
> Pushed by mlaurent into branch 'release/19.12'.
> 
> Fix Bug 415254 - [regression] HTML viewer complains about "external
> references to images etc." when there are no images
> 
> FIXED-IN: 5.13.1
> 
> M  +2    -2   
> messageviewer/src/messagepartthemes/default/defaultrenderer.cpp
> 
> https://commits.kde.org/messagelib/56f1d42f68ed2f597fc599e4952ee81e579cd355

+    if (str.contains(QRegularExpression(QLatin1String("<img.*src=http:/"),
QRegularExpression::CaseInsensitiveOption))
+        || str.contains(QRegularExpression(QLatin1String("<img.*src=https:/"),
QRegularExpression::CaseInsensitiveOption))) {

How about <img src="https://...">, with the quotes? The code above this section
deals with href=", but not src=. 

This will also trigger as a false positive in the following HTML:

<img src="cid:parn-num">Some text goes here blah blah src=http://example.com

-- 
You are receiving this mail because:
You are the assignee for the bug.