[korganizer] [Bug 382185] resources color is only used for border

[Denis Kurz]

https://bugs.kde.org/show_bug.cgi?id=382185

Denis Kurz <kdenis at posteo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.9.3
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/eve
                   |                            |ntviews/0b12580c8e848089a37
                   |                            |3dadae1c3e12b3ea0a531

--- Comment #10 from Denis Kurz <kdenis at posteo.de> ---
Git commit 0b12580c8e848089a373dadae1c3e12b3ea0a531 by Denis Kurz.
Committed on 11/10/2018 at 21:22.
Pushed by dkurz into branch 'Applications/18.08'.

Fix color inconsistency for unset categories.

Summary:
KOrganizer's preference dialog states that the color for unset
categories is only used on the categories-color-only setting. However,
this is currently not true for Month View, where in each of the mixed
settings (category-border, resource-fill, or vice versa) the
unset-category color is also used. With this patch, Month View considers
the unset-category color only in the category-only setting, just like
Agenda View.
FIXED-IN: 5.9.3

Test Plan:
By testing all four combinations for coloring frame and fill
a month item, I confirmed Bug 382185: the color for items with no
categories is used in CategoryOnly as well as in mixed settings (i.e.,
all settings but ResourceOnly). After applying this patch, I tested them
again and confirmed that the unset-category color is only used in
CategoryOnly, while in mixed settings, the resource color is used instead,
making it consistent to Agenda View and the settings dialog.

Reviewers: #kde_pim, dvratil

Reviewed By: #kde_pim, dvratil

Subscribers: dvratil, kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D16088

M  +31   -45   src/month/monthitem.cpp
M  +2    -2    src/month/monthitem.h

https://commits.kde.org/eventviews/0b12580c8e848089a373dadae1c3e12b3ea0a531

-- 
You are receiving this mail because:
You are the assignee for the bug.