[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet

[Krzysztof Nowicki]

https://bugs.kde.org/show_bug.cgi?id=393002

Krzysztof Nowicki <krissn at op.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |pim-runtime/b5ee6ff11cd3a7e
                   |                            |0c28305b351d28c5f244f101e
         Resolution|---                         |FIXED

--- Comment #5 from Krzysztof Nowicki <krissn at op.pl> ---
Git commit b5ee6ff11cd3a7e0c28305b351d28c5f244f101e by Krzysztof Nowicki.
Committed on 29/05/2018 at 10:02.
Pushed by nowicki into branch 'Applications/18.04'.

resources/ews: Fix saving passwords to KWallet

This is a regression after switching to asynchronous wallet
opening. When saving the password the wallet is opened and a callback is
registered to write the password once the wallet is ready. Unfortunately
all this is done in an instance of the EwsSettings class that is local
to the configuration dialog class. This means that this instance is
destroyed once the configuration dialog is dismissed, so when opening
the wallet takes a split second too long the object dies before the
callback has a chance to do its job.

The fix is not to use a local instance of the EwsSettings class in the
configuration dialog and instead work on a pointer to this object kept
by the root resource class, which is alive at all times.

M  +3    -2    resources/ews/ewsconfigdialog.cpp
M  +4    -2    resources/ews/ewsconfigdialog.h
M  +1    -1    resources/ews/ewsresource.cpp

https://commits.kde.org/kdepim-runtime/b5ee6ff11cd3a7e0c28305b351d28c5f244f101e

-- 
You are receiving this mail because:
You are on the CC list for the bug.