[frameworks-kholidays] [Bug 365241] The information on Japanese holidays is outdated

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=365241

phanective at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |phanective at gmail.com
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #7 from phanective at gmail.com ---
Hey Allen, did you read diff (
https://cgit.kde.org/kholidays.git/commit/?id=49f6abb6035f97c0a98113e3aedf5d2db135bf63
) when you merge the attached files?
The code attached by Firas is based on quite old codebase (July 2016) and it
reverts my updates done in May 2017:

https://phabricator.kde.org/D5736
https://cgit.kde.org/kholidays.git/commit/?id=f6044686a1768565bcf3d91489f1b080d64c8666

It removes metadata, re-add non-existing holidays (The days listed in
"Cultural" section including St. Valentine's Day, Girls' Festival, and Buddha's
Birthday are not holidays in Japan), removes comments referring governmental
information about holidays.

I think your commit 49f6abb should be reverted.
I opened request to revert 49f6abb:
https://phabricator.kde.org/D13812

-- 
You are receiving this mail because:
You are the assignee for the bug.