[Akonadi] [Bug 389607] akonadictl fsck: Show more helpful messages

[Daniel Vrátil]

https://bugs.kde.org/show_bug.cgi?id=389607

Daniel Vrátil <dvratil at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dvratil at kde.org

--- Comment #2 from Daniel Vrátil <dvratil at kde.org> ---
> Of course, even better would be if akonadictl fsck could fix the issues it finds.

Yes, but not everything is an issue.

> Some suggestions to improve the situation:
> Item "1289323" has no RID. =>
>
> Item "1289323" only stored in database, not locally in XYZ resource.
>
> XYZ should be the name of the affected resource.

There are two problems:
1) The item can be owned by an online Resource (e.g. IMAP) and the Item may
have no RID simply because the Resource wasn't online yet. In such case the
situation above is not an error.

2) Your message is not precise. "locally in XYZ resource" is wrong, again in
case of online resource. I don't want fsck to contain misguiding messages. In
its own way, the current message (Item has no RID) is perfect, because
describes the situation perfectly. I think the best way would be to just add a
link to Wiki where the issue is described in detail.

> Item "1360766" has RID and is dirty. =>
> 
> Item "1360766" has changes that are only stored in the database, not locally in XYZ resource

Again, the case can simply be because the change couldn't be replayed by an
online Resource yet because it's offline. Same solution as above would apply.

> => Exactly tell which files are identically to give the user the chance to remove duplicate files. It is not obvious from the above:

The "duplicate" refers to duplicate RID, meaning there are multiple Items
stored in the database that belong to the same Collection and have the same
RID. That in no way implies there's a duplicate in the backing storage (maildir
or IMAP) and in most cases there's not even any actual file to refer to (e.g.
IMAP).

-- 
You are receiving this mail because:
You are the assignee for the bug.