[korganizer] [Bug 356053] Crash if I close the korganizer window while adding a new attachment

[Denis Kurz]

https://bugs.kde.org/show_bug.cgi?id=356053

Denis Kurz <kdenis at posteo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.6.1
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/inc
                   |                            |idenceeditor/c1f5f69291226f
                   |                            |b08d1d744059243f71b91fbacb

--- Comment #3 from Denis Kurz <kdenis at posteo.de> ---
Git commit c1f5f69291226fb08d1d744059243f71b91fbacb by Denis Kurz.
Committed on 04/02/2018 at 20:12.
Pushed by dkurz into branch 'Applications/17.12'.

Fix use-after-free

Summary:
We now detect if IncidenceAttachment is deleted while the
AttachmentEditDialog is shown. There were three potential crashes
(deletion of item; access to mAttachmentView; call checkDirtyStatus);
the first of them actually was met in the wild in Bug 356053. Fixing
only the deletion of item led to the other two.
FIXED-IN: 5.6.1

Test Plan:
Compiled; repeated the steps described in Bug 356053. The crash
happens without the patch; doesn't happen with the patch.

Reviewers: #kde_pim, dvratil

Reviewed By: #kde_pim, dvratil

Subscribers: winterz

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D7591

M  +10   -8    src/incidenceattachment.cpp

https://commits.kde.org/incidenceeditor/c1f5f69291226fb08d1d744059243f71b91fbacb

-- 
You are receiving this mail because:
You are the assignee for the bug.