[kmail2] [Bug 383070] Crash in GrantleeTheme::ThemeManager::Private::updateActionList() when reinstalling KMail at runtime

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=383070

David Faure <faure at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |18.04
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |pim-addons/f3da346dcecd7d8f
                   |                            |f83582a24b0bcc4ce01d4302
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from David Faure <faure at kde.org> ---
Git commit f3da346dcecd7d8ff83582a24b0bcc4ce01d4302 by David Faure.
Committed on 22/04/2018 at 08:58.
Pushed by dfaure into branch 'Applications/18.04'.

Fix GrantleeTheme::ThemeManager being leaked.

Summary:
When a Viewer was deleted, its ThemeManager was kept alive.
So it would still react to KDirWatch (when installing files) and it
would try to update a menu (QActionGroup) that was deleted with the
viewer.
FIXED-IN: 18.04

Test Plan:
KMail, Enter to open separate viewer, Alt+F4, (uncommitted)
debug output shows that now the ThemeManager is deleted, while it wasn't
before.

Reviewers: mlaurent

Reviewed By: mlaurent

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D12431

M  +1    -1   
plugins/messageviewerheaderplugins/grantleeheaderstyleplugin/grantleeheaderstyleinterface.cpp

https://commits.kde.org/kdepim-addons/f3da346dcecd7d8ff83582a24b0bcc4ce01d4302

-- 
You are receiving this mail because:
You are the assignee for the bug.