[kcalcore] [Bug 392952] New: Regression: port to QTimeZone leads to blowing up iCal file size

[Jochen Trumpf]

https://bugs.kde.org/show_bug.cgi?id=392952

            Bug ID: 392952
           Summary: Regression: port to QTimeZone leads to blowing up iCal
                    file size
           Product: kcalcore
           Version: git
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: kdepim-bugs at kde.org
          Reporter: Jochen.Trumpf at anu.edu.au
  Target Milestone: ---

Created attachment 111933
  --> https://bugs.kde.org/attachment.cgi?id=111933&action=edit
fix for repeated VTIMEZONE entries in iCal resource

Commit
https://cgit.kde.org/kcalcore.git/commit/?h=Applications/17.12&id=d90afd544828cc3391720c7aaf9135fa577f303a
introduced an unintended side effect that is blowing up iCal file sizes by
storing a VTIMEZONE entry per event instead of a consolidated list.

The issue is ultimately caused by the replacement of the QMap based
ICalTimeZones class with a QVector based type for tzUsedList. The
ICalTimeZones::add method did check whether a to be added timezone is already
in the map, whereas the replacement QVector::push_back method does not.

The bug occurs in lines 2419-2421 (Application/17.12 branch) of
icalformat_p.cpp and is easily fixed with the attached patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.