[kmime] [Bug 385479] New: KMime DateFormatterTest fails with fancy format

[A. Wilcox (awilfox)]

https://bugs.kde.org/show_bug.cgi?id=385479

            Bug ID: 385479
           Summary: KMime DateFormatterTest fails with fancy format
           Product: kmime
           Version: unspecified
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: kdepim-bugs at kde.org
          Reporter: awilfox at adelielinux.org
  Target Milestone: ---

12/17 Test #12: kmime-dateformattertest ..........***Failed    0.00 sec
********* Start testing of DateFormatterTest *********
Config: Using QtTest library 5.9.1, Qt 5.9.1 (x86_64-little_endian-lp64 shared
(dynamic) release build; by GCC 6.4.0)
PASS   : DateFormatterTest::initTestCase()
FAIL!  : DateFormatterTest::testFancyFormat() Compared values are not the same
   Actual   (f.dateString(dt))                     : "Today 12:34"
   Expected (QString::fromLatin1("Today 12:34:56")): "Today 12:34:56"
   Loc:
[/usr/src/packages/user/kmime/src/kmime-17.08.1/autotests/dateformattertest.cpp(40)]
PASS   : DateFormatterTest::testLocalizedFormat()
PASS   : DateFormatterTest::cleanupTestCase()
Totals: 3 passed, 1 failed, 0 skipped, 0 blacklisted, 0ms
********* Finished testing of DateFormatterTest *********


Internally, fancy format uses QLocale::ShortFormat, which is of course
non-portable.  This could mean anything, and on Mac OS X and Windows it is even
user-customisable.  I would personally either not test Fancy Format, or if you
must test Fancy Format for the "Today" / "Yesterday" feature, then call
QTime::toString(ShortFormat) on the 12:34:56 time specified for that part of
the return value instead of relying on the format being hh:mm:ss.

-- 
You are receiving this mail because:
You are the assignee for the bug.