[kleopatra] [Bug 192059] Unable to add more than one keyserver to the directory services configuration

[Andre Heinecke]

https://bugs.kde.org/show_bug.cgi?id=192059

Andre Heinecke <aheinecke at intevation.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/lib
                   |                            |kleo/aec263d7ff0ea727a730f6
                   |                            |57439e4945ba88b18a

--- Comment #6 from Andre Heinecke <aheinecke at intevation.de> ---
Git commit aec263d7ff0ea727a730f657439e4945ba88b18a by Andre Heinecke.
Committed on 15/05/2017 at 14:37.
Pushed by aheinecke into branch 'master'.

Simplify and split DirectoryServicesWidget

The old UI was probably written under the assumption that there
will be support for multiple OpenPGP Keyserver entries at some point.
We now only support a single entry for keyserver.
As GnuPG only supports a single Keyserver URL the old widget
lead to confusion and buggy behavior as it allowed the user to
configure multiple PGP Keyservers which were not respected or
could not be configured through gpgconf.

GnuPG since 2.1.16 has a built in keyserver URL, the placeholder
text in the line entry when no other keyserver is configured is
intended to reflect that.

API compatibility is kept with the old widget operation. Even though
I doubt that the read only settings are actually used in practice.

While this fixes bugs let's keep it in master because of regression
risks.
Related: bug 359151

M  +80   -295  src/ui/directoryserviceswidget.cpp
M  +0    -2    src/ui/directoryserviceswidget.h
M  +109  -104  src/ui/directoryserviceswidget.ui

https://commits.kde.org/libkleo/aec263d7ff0ea727a730f657439e4945ba88b18a

-- 
You are receiving this mail because:
You are on the CC list for the bug.