[Akonadi] [Bug 377897] Findings from code review

Daniel Vrátil bugzilla_noreply at kde.org
Wed Mar 22 00:29:05 GMT 2017


https://bugs.kde.org/show_bug.cgi?id=377897

--- Comment #2 from Daniel Vrátil <dvratil at kde.org> ---
Thanks for the review! 

The leaked FDs are false positives, as the FD is passed into QLocalSocket which
then takes ownership and ensures they are freed when the QLocalSocket is
destroyed.

The "identical branches" warnings are from a generated code (code generated by
Qt during compilation), so nothing I can fix easily.

I fixed the missing return, missing break, and double return issues. Thanks
again!

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Kdepim-bugs mailing list