[Akonadi] [Bug 387926] Release version 17.12: Sending a mail with SMTP fails with: org.kde.pim.ksmtp: Socket error: 1

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=387926

Fabian Vogt <fabian at ritter-vogt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/ksm
                   |                            |tp/5199ed07428a03f1aa340da3
                   |                            |ae99fcfa62ba2751
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED FIXED
      Latest Commit|                            |https://commits.kde.org/ksm
                   |                            |tp/ec2afd27c790fbde63a9c2bd
                   |                            |d1f97a59fe04b18e
             Status|CONFIRMED                   |RESOLVED

--- Comment #32 from Fabian Vogt <fabian at ritter-vogt.de> ---
Git commit 5199ed07428a03f1aa340da3ae99fcfa62ba2751 by Fabian Vogt.
Committed on 23/12/2017 at 12:09.
Pushed by fvogt into branch 'Applications/17.12'.

Send the correct hostname with the HELO/EHLO command

Summary:
It sent the server's hostname previously, which some reject.

Test Plan: Ran nc as smtp server, uses the right hostname for EHLO now.

Reviewers: mlaurent, dvratil

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D9485

M  +13   -1    src/session.cpp

https://commits.kde.org/ksmtp/5199ed07428a03f1aa340da3ae99fcfa62ba2751

--- Comment #33 from Fabian Vogt <fabian at ritter-vogt.de> ---
Git commit ec2afd27c790fbde63a9c2bdd1f97a59fe04b18e by Fabian Vogt.
Committed on 23/12/2017 at 12:09.
Pushed by fvogt into branch 'Applications/17.12'.

Fix duplicate authentication

Summary:
The response to EHLO triggers an authentication command, but with TLS
two EHLOs are sent: For the 220 from the server and after TLS negotiation.
However, sending it twice results in an unexpected "503 already authenticated"
response which ends up getting parsed by the SendJob, causing confusion.

By leaving the EHLO-resending to the SessionPrivate, the state can be properly
tracked.
Related: bug 388068

Reviewers: mlaurent, dvratil

Subscribers: lbeltrame, cgiboudeaux

Differential Revision: https://phabricator.kde.org/D9476

M  +19   -10   src/session.cpp
M  +1    -0    src/session_p.h
M  +0    -1    src/sessionthread.cpp

https://commits.kde.org/ksmtp/ec2afd27c790fbde63a9c2bdd1f97a59fe04b18e

-- 
You are receiving this mail because:
You are the assignee for the bug.