[korganizer] [Bug 373257] unwanted new categories with UUID-like names

[Denis Kurz]

https://bugs.kde.org/show_bug.cgi?id=373257

Denis Kurz <kdenis at posteo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.6.1
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/inc
                   |                            |idenceeditor/b807715001e83a
                   |                            |be4335b48ab4f2b424410bcec4

--- Comment #2 from Denis Kurz <kdenis at posteo.de> ---
Git commit b807715001e83abe4335b48ab4f2b424410bcec4 by Denis Kurz.
Committed on 25/08/2017 at 22:48.
Pushed by dkurz into branch 'Applications/17.08'.

Prevent tag name vs gid confusion

Summary:
The old code relied on the display name of the tags of the item provided
via load(const Akonadi::Item&) being set, but those aren't actually
fetched. This led IncidenceCategories to believe that an item's
categories are the gids of its tags. Saving the item without confirming
the category dialog (e.g. by only modifying the description) led to this
gid being written back to Akonadi. Opening the item again afterwards
then even leads to a corresponding Akonadi tag being created.

We reduce state in IncidenceEditor, stop matching Tags twice a
row (in onTagsFetched and matchExistingCategories), and rely more on
incidence->categories(), where no gid confusion exists.
FIXED-IN: 5.6.1

Test Plan:
I editted multiple events in KOrganizer, modifying categories or
description or title of the event, or all of them in one change.
For categories, I tried to set related subsets of my tags (a sub-
or superset of the previously selected tags), or completely unrelated
sets (deselecting all selected, and selecting previously other ones
instead). All changes were saved as expected, and no gid-named
categories were created in the process.

Reviewers: #kde_pim, dvratil

Reviewed By: #kde_pim, dvratil

Subscribers: dvratil

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D7548

M  +31   -35   src/incidencecategories.cpp
M  +0    -3    src/incidencecategories.h

https://commits.kde.org/incidenceeditor/b807715001e83abe4335b48ab4f2b424410bcec4

-- 
You are receiving this mail because:
You are the assignee for the bug.