[kmail2] [Bug 362958] After update KMail not interpreting Invite Emails

[Fabian Vogt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362958

--- Comment #38 from Fabian Vogt <fabian at ritter-vogt.de> ---
(In reply to Sandro Knauß from comment #37)
> Git commit 9b23c8b270bb1555ef9d1b1751fd987675c6279c by Sandro Knauß.
> Committed on 26/07/2016 at 10:27.
> Pushed by knauss into branch 'Applications/16.08'.
> 
> Render multipart/alternative with a invitation correctly
> 
> alternative parts can also have a calender element, so we want to render
> that.
> 
> M  +1    -1    CMakeLists.txt
> M  +6    -6   
> messageviewer/src/messagepartthemes/default/autotests/objecttreeparsertest.
> cpp
> M  +12   -13  
> messageviewer/src/messagepartthemes/default/autotests/setupenv.h
> M  +17   -8   
> messageviewer/src/messagepartthemes/default/defaultrenderer.cpp
> M  +7    -6    messageviewer/src/viewer/objecttreeemptysource.cpp
> M  +2    -2    messageviewer/src/viewer/objecttreeemptysource.h
> M  +19   -6    messageviewer/src/viewer/objecttreeviewersource.cpp
> M  +2    -2    messageviewer/src/viewer/objecttreeviewersource.h
> M  +2    -1    messageviewer/src/viewer/viewer.h
> M  +27   -2    messageviewer/src/viewer/viewer_p.cpp
> M  +2    -0    messageviewer/src/viewer/viewer_p.h
> M  +18   -1    messageviewer/src/widgets/htmlstatusbar.cpp
> M  +4    -0    messageviewer/src/widgets/htmlstatusbar.h
> M  +12   -13   mimetreeparser/autotests/setupenv.h
> M  +26   -35   mimetreeparser/src/bodyformatter/multipartalternative.cpp
> M  +3    -4    mimetreeparser/src/interfaces/objecttreesource.h
> M  +2    -1    mimetreeparser/src/utils/util.h
> M  +68   -32   mimetreeparser/src/viewer/messagepart.cpp
> M  +13   -9    mimetreeparser/src/viewer/messagepart.h
> M  +5    -3    mimetreeparser/src/viewer/objecttreeparser.cpp
> 
> http://commits.kde.org/messagelib/9b23c8b270bb1555ef9d1b1751fd987675c6279c

In messageviewer/src/viewer/viewer_p.cpp:
> +    const int pos = (availableModes.indexOf(mode) + 1) % availableModes.size();

"%" is dangerous. If availableModes is empty, it'll crash here. AFAICS it's not
possible to reach that state, but it's not obvious at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.