[kleopatra] [Bug 357933] Kleopatra 15.12.1 (2.2): load certifications (pgp) - segfault after infinite recursion

Andre Heinecke via KDE Bugzilla bugzilla_noreply at kde.org
Fri Feb 19 14:25:05 GMT 2016


https://bugs.kde.org/show_bug.cgi?id=357933

Andre Heinecke <aheinecke at intevation.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/kdep
                   |                            |im/35bbcb687537628e0c7facc8
                   |                            |3ca2c175e3d22d3b
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Andre Heinecke <aheinecke at intevation.de> ---
Git commit 35bbcb687537628e0c7facc83ca2c175e3d22d3b by Andre Heinecke.
Committed on 19/02/2016 at 14:22.
Pushed by aheinecke into branch 'master'.

Refactor UserID Certificate details

The old code was obscurely optimized to avoid copying data
for the useridmodel. The userID model is fairly small as it
only works with the Signatures of the UIDs of a single key.
In most cases this is not much data. Keys with more then
a thousand signatures are rare and even those modern Systems
handle easily.

Reflecting this the option to specifically load certifications
is gone. Even for keys with lots of signatures liek
0xE3EDFAE3 or 0xD21739E9 this feels like instant. So no need
to hassle a user that explicitly selects UserID and Certification
details with yet another click to load them.

This also changes the UserIDListModel API to a Qt API.
REVIEW: 127059

M  +14   -32   kleopatra/dialogs/certificatedetailsdialog.cpp
M  +0    -1    kleopatra/dialogs/certificatedetailsdialog.h
M  +0    -10   kleopatra/dialogs/certificatedetailsdialog.ui
M  +185  -239  kleopatra/models/useridlistmodel.cpp
M  +10   -32   kleopatra/models/useridlistmodel.h

http://commits.kde.org/kdepim/35bbcb687537628e0c7facc83ca2c175e3d22d3b

-- 
You are receiving this mail because:
You are on the CC list for the bug.



More information about the Kdepim-bugs mailing list