[kmail2] [Bug 336653] kmail inverts HTML view settings

[Thomas Tanghus]

https://bugs.kde.org/show_bug.cgi?id=336653

--- Comment #2 from Thomas Tanghus <thomas at tanghus.net> ---
OK, it seems I have found the reason:

I tried a while ago to have a separate addressbook for whitelisting specific
email adresses to show as HTML and load external references.
As that was ignored in previous versions I disabled the addressbook and went
back to just having it as default.
Now the contact specific settings is taken into account, instead of using that
setting, it inverts the global setting!

This sounds like an honest mistake and an easy fix.

My guess is that it is coded like this (pseudo code)

renderHTML = globalRenderHTML;
if(contactSettingRenderHTML) {
    renderHTML = !globalRenderHTML;
}

Where instead it should be:

renderHTML = globalRenderHTML;
if(contactSettingRenderHTML) {
    renderHTML = contactSettingRenderHTML;
}

While fixing it please consider only rendering the content after any contact
specific setting has been read, because as it is now it first shows the plain
text version and then afterwards it renders the HTML version.
Also the addressbook in question was disabled. Shouldn't disabled addressbooks
be ignored? Even though I would never have found the reason if they were ;)

But great that whitelisting email addresses this way works now :)

-- 
You are receiving this mail because:
You are the assignee for the bug.