[Akonadi] [Bug 330010] KDEPIM .desktop file parser considers invalid the strings containing commas

[Alexander Potashev]

https://bugs.kde.org/show_bug.cgi?id=330010

--- Comment #4 from Alexander Potashev <aspotashev at gmail.com> ---
Dan,
Let's hope there are no languages in which there should be no space after a
comma. According to the current .desktop files for Akonadi agents, it is so for
the languages we already have translations to.

(In reply to comment #3)
> Git commit f28b675e7361b96c32a136c7eda7e4ef864eb432 by Dan Vrátil.
> Committed on 17/01/2014 at 14:06.
> Pushed by dvratil into branch '1.11'.
> 
> Fix parsing of .desktop files entries with comma in value
> 
> We are using QSettings to parse .desktop files. QSettings however treats
> a value with comma as a QStringList which is not compatible with KConfig's
> behavior, because KConfig treats everything as a string by default.
> 
> This patch adds a small workaround for this QSettings behaviour and joins
> the list back to a single string when a string value is expected.
> 
> For translators this means that Comment entries in Akonadi agents' .desktop
> files don't have to be enclosed in double quotes anymore.
> FIXED-IN: 1.11.1
> 
> M  +31   -5    server/control/agenttype.cpp
> M  +3    -0    server/control/agenttype.h
> 
> http://commits.kde.org/akonadi/f28b675e7361b96c32a136c7eda7e4ef864eb432

-- 
You are receiving this mail because:
You are the assignee for the bug.