[Akonadi] [Bug 328286] Broken logic in DataStore::setItemFlags causes flags to be erroneously removed

[Tomas Trnka]

https://bugs.kde.org/show_bug.cgi?id=328286

Tomas Trnka <tomastrnka at gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |1.11.1
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/akon
                   |                            |adi/daa2e624c64cafb6ec9ac6f
                   |                            |2a619a896588eb254

--- Comment #2 from Tomas Trnka <tomastrnka at gmx.com> ---
Git commit daa2e624c64cafb6ec9ac6f2a619a896588eb254 by Tomáš Trnka.
Committed on 01/12/2013 at 17:39.
Pushed by ttrnka into branch 'master'.

Don't do redundant flag changes in setItemsFlags

Instead of removing all flags and then adding the requested ones
back, figure out which flags are actually getting added or removed
and only apply those changes.

Everything is still carried out in up to two DB queries.

Additionally, don't send out the change notification if nothing
has actually changed.
FIXED-IN:1.11.1
REVIEW:114241

M  +29   -29   server/src/storage/datastore.cpp

http://commits.kde.org/akonadi/daa2e624c64cafb6ec9ac6f2a619a896588eb254

-- 
You are receiving this mail because:
You are the assignee for the bug.