[Bug 306323] [kdepimlibs] missed boost dependency in KdepimLibsConfig.cmake.in

[Christophe Giboudeaux]

https://bugs.kde.org/show_bug.cgi?id=306323

--- Comment #17 from Christophe Giboudeaux <cgiboudeaux at gmx.com> ---
(In reply to comment #14)
> (In reply to comment #13)
> > The idea and the patch are both wrong.
> > 
> > - Adding the boost include dir to kdepimlibs_include_dirs supposes that :
> > 1/ Boost was already found,
> yes it was! it was detected by root's CMakeLists.txt while compile... after
> that, if pykde for example, starts to compile on same host boost definitely
> will be here.

You misunderstand what KdepimLibsConfig.cmake.in does: ${boost_include_dir} is
not replaced by the boost include dir. KdepimLibsConfig.cmake will contain the
exact same variable.

When used in, say pykde, it will have no value because nothing will have looked
for boost.

You'll get a similar result with this test CMakeLists.txt:
project(test)
message(STATUS "boost_include_dir: ${boost_include_dir}")

result: the variable is empty because nothing will define it.

Please note that:
- *ALL* the KDE projects' CMakeLists.txt already have an include_directories
line (for the kdelibs and Qt includes). So adding one for boost when it's
needed is not a big deal.

- There's no reason to have a special rule for boost in kdepimlibs (we have
many 3rd party dependencies used in the project such as libical, libprison,
libprison's dependencies, kdelibs, Qt and even the akonadi server is included)

-- 
You are receiving this mail because:
You are the assignee for the bug.