[Bug 306323] [kdepimlibs] missed boost dependency in KdepimLibsConfig.cmake.in

[Alex Turbov]

https://bugs.kde.org/show_bug.cgi?id=306323

Alex Turbov <i.zaufi at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |---

--- Comment #5 from Alex Turbov <i.zaufi at gmail.com> ---
(In reply to comment #4)
> Fix pyKDE and not kdepimlibs
> or report it to pyKDE
> 
> As I told you we added ${Boost_INCLUDE_DIR} in kdepim when necessary
> => add it in pyKDE

maybe it would be better to look into sources before telling...
---
zaufi at gentop /work/kdepimlibs-4.9.1 $ cat CMakeLists.txt | head -n 69 | tail -n
6
set(Boost_MINIMUM_VERSION "1.34.0")
if (WIN32)
  find_package(Boost ${Boost_MINIMUM_VERSION}) # (jstaniek) temp. fix unless we
have graph library, not just headers
else()
  find_package(Boost ${Boost_MINIMUM_VERSION} COMPONENTS graph)
endif()
---
as u may c boost would be checkd ALWAYS. Lets check the header files where
boost headers are included:
zaufi at gentop /work/kdepimlibs-4.9.1 $ grep -nr --include=*.h "#include <boost"
* | wc -l
63
zaufi at gentop /work/kdepimlibs-4.9.1 $ grep -r --include=*.h "#include <boost" *
| sed 's,.*#include <\(.*\)>,\1,' | sort | uniq
boost/bind.hpp
boost/enable_shared_from_this.hpp
boost/mpl/eval_if.hpp
boost/mpl/identity.hpp
boost/optional.hpp
boost/scoped_ptr.hpp
boost/shared_ptr.hpp
boost/static_assert.hpp
boost/type_traits/is_pointer.hpp
boost/type_traits/is_same.hpp
boost/type_traits/remove_pointer.hpp
boost/utility/enable_if.hpp
boost/variant.hpp
boost/weak_ptr.hpp
---

so u r trying to tell me that I have to report to undefined number of OTHER
applications which r use kdepimlibs to fix their kdepimlibs detection scripts
for IMPLICIT dependency on boost??? ARE YOUR SERIOUS/CRAZY!? It is ONLY
kdepimlibs dependency!!! And it is EXPLICIT! kdepimlibs MUST provide a
(self-sufficient) configuration file which, being used, allows to ANY other
appication to detect EVERYTHING that require to successfull compilation/linking
w/ kdepimlibs! If I use kdepimlibs in my application I want to detec ONLY
kdepimlibs... I dont care about everything this library depends on!! Following
your "logic" other applcations have to check for kdelibs, qt4, x11 libs & etc
when they just wants to use kdepimlibs!!!! its completely INCORECT!

wbr

PS: google for library design best practices

-- 
You are receiving this mail because:
You are the assignee for the bug.