[Bug 308480] New: vCards get imported/exported with incorrect Photo Format Type

[fetzer.ch at googlemail.com]

https://bugs.kde.org/show_bug.cgi?id=308480

            Bug ID: 308480
          Severity: normal
           Version: GIT (master)
          Priority: NOR
          Assignee: kdepim-bugs at kde.org
           Summary: vCards get imported/exported with incorrect Photo
                    Format Type
    Classification: Unclassified
                OS: Linux
          Reporter: fetzer.ch at googlemail.com
          Hardware: Other
            Status: UNCONFIRMED
         Component: kabc
           Product: kdepimlibs

When adding images to the contact resource in akonadi (via KAddressBook) the
Photo Format Type in the PHOTO tag is set incorrectly. It uses a mime type
representation ("image/jpeg" or "image/png").
For example: PHOTO;ENCODING=b;TYPE=image/jpeg:/9j/4AAQSkZJR...

This is wrong for vCard 2.1 and 3.0. It says in the vCard 3.0 spec: 'The TYPE
parameter values MUST be one of the IANA registered image formats or a
non-standard image format.' 
(see here: vCard 2.1: http://www.imc.org/pdi/vcard-21.doc, page 10; 3.0:
http://www.rfc-editor.org/rfc/rfc2426.txt, page 9).
Correct would be: PHOTO;ENCODING=b;TYPE=JPEG:/9j/4AAQSkZJR...

The problem seems to be in VCardTool::createPicture(...) (vcardtool.cpp:854)
but I'm not sure if fixing it here is enough.

Reproducible: Always

Steps to Reproduce:
1. Open KAddressBook and add a photo to a contact
2. Open Aconadi Console, switch to browser and select your contact resource
3. Select the relevant vcf file and see it's 'Raw Payload'
Actual Results:  
The raw payload shows:
PHOTO;ENCODING=b;TYPE=image/jpeg:/9j/4AAQSkZJR...

Expected Results:  
While it should actually be:
PHOTO;ENCODING=b;TYPE=JPEG:/9j/4AAQSkZJR...

The issue prevents for example proper syncing with syncevolution.

-- 
You are receiving this mail because:
You are the assignee for the bug.