[Bug 310469] ical implementation mixed up dtstamp and dtcreated.

[Christian Mollekopf]

https://bugs.kde.org/show_bug.cgi?id=310469

Christian Mollekopf <chrigi_1 at fastmail.fm> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |4.9.5
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kdep
                   |                            |imlibs/c32e7b2b16eaa2d676ab
                   |                            |e8a8456dc05d0bd62793

--- Comment #1 from Christian Mollekopf <chrigi_1 at fastmail.fm> ---
Git commit c32e7b2b16eaa2d676abe8a8456dc05d0bd62793 by Christian Mollekopf.
Committed on 26/11/2012 at 20:04.
Pushed by cmollekopf into branch 'KDE/4.9'.

Don't mix up CREATED and DTSTAMP, and introduce X-KDE-IMPLEMENTATION-VERSION.

CREATED is the creation-date of the icalendar object, and not the time of
serialization.
DTSTAMP is the last-modification-date without METHOD, and the time of
serialization with a METHOD.

This patch fixes the following problems:
* dtstamp and created exchanged when writing any ical object
* created date is not preserved
* last-modification-date is not preserved
* vFreebusy iTip messages contain a created date (but must not)

Backwardscompatibility is ensured by only applying the fix for ical
objects which have been written using the new implementation.

For this X-KDE-IMPLEMENTATION-VERSION has been introduced to track the
implementation version which makes it possible to provide proper
backwards compatiblity.
REVIEW: 107480
FIXED-IN: 4.9.5

M  +77   -3    kcalcore/compat.cpp
M  +80   -1    kcalcore/compat.h
M  +53   -10   kcalcore/icalformat_p.cpp
M  +6    -0    kcalcore/icalformat_p.h
M  +1    -0    kcalcore/tests/CMakeLists.txt
A  +80   -0    kcalcore/tests/testcreateddatecompat.cpp     [License: LGPL
(v3+)]
A  +34   -0    kcalcore/tests/testcreateddatecompat.h     [License: LGPL (v3+)]

http://commits.kde.org/kdepimlibs/c32e7b2b16eaa2d676abe8a8456dc05d0bd62793

-- 
You are receiving this mail because:
You are the assignee for the bug.