[Bug 273991] Mark message as ... submenu grows way too big when user has defined many tags

[Sven Wehner]

https://bugs.kde.org/show_bug.cgi?id=273991





--- Comment #3 from Sven Wehner <sven atelophobia de>  2011-09-22 23:40:34 ---
Created an attachment (id=63872)
 --> (http://bugs.kde.org/attachment.cgi?id=63872)
Patch that extends the Tag::compare() method

This patch tries (!) to extend the compare() method.

The current version of tag.cpp sorts based on the priority of the tags only.
But it seems to be seldom (never? I used nepomukshell to find a tag that had a
priority property...) set, and therefore a default value (-1) is used. And
thus, the sort order is more or less arbitrary.
The patch makes the compare() method use also the tags' names, when the
priority is equal.

Additionally a second compare method is introduced: compareName(). This method
ignores the priority and compares only based on tag name.

The patch was written against the source code of the 4.7.1 version, but it
should also apply in the trunk, because there haven't been any changes on
tag.{h,cpp} for quite some time.


Question: What is the priority for, and why does no one uses it? The source
code states "sort order of the tag", but I couldn't see that.
(Would be great if it would be something like a measure of uses or recently
uses...)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.