[Bug 274937] New: kabcclient's mutt output repeats first name

[Fernando Schapachnik]

https://bugs.kde.org/show_bug.cgi?id=274937

           Summary: kabcclient's mutt output repeats first name
           Product: kdepim
           Version: 4.4
          Platform: FreeBSD Ports
        OS/Version: FreeBSD
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkdepim
        AssignedTo: kdepim-bugs at kde.org
        ReportedBy: fernando at schapachnik.com.ar


Created an attachment (id=60628)
 --> (http://bugs.kde.org/attachment.cgi?id=60628)
Solves problem and adds 'includenickname' functionality

Version:           4.4 (using KDE 4.5.5) 
OS:                FreeBSD

kabcclient --list --of mutt reports
alias jdoe John John <jdoe at example.com>
instead of
alias jdoe John Doe <jdoe at example.com>

It behaves like that despite the 'altkeys' option being used or not.

Reproducible: Always

Steps to Reproduce:
Run kabcclient --list --of mutt

Actual Results:  
alias jdoe John John <jdoe at example.com>

Expected Results:  
alias jdoe John Doe <jdoe at example.com>

The code at kdepim-4.4.11.1/console/kabcclient/src/outputformatimpls.cpp
said:

stream << fromUnicode(m_codec, addressee.givenName()) << " "
       << fromUnicode(m_codec, addressee.familyName())<< " <"
       << fromUnicode(m_codec, *it)                   << ">";

For some reason the stream would get corrupted and either repeat the second
parameter or put garbage instead of it (in some tests).

The solution was splitting the call to the stream as in:


stream << fromUnicode(m_codec, addressee.givenName()) << " ";
stream << fromUnicode(m_codec, addressee.familyName())<< " <"
       << fromUnicode(m_codec, *it)                   << ">";

Also, I wanted to have aliases for nicknames, so if John Doe has a nick name
johnny, I can have also

alias johnny Joe Doe <jdoe at example.com>

To that purpose the attached patch adds the option 'includenickname'.

Thanks!

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.