[Bug 289277] New: kmail_clamav.sh causes email duplication

[Doron]

https://bugs.kde.org/show_bug.cgi?id=289277

           Summary: kmail_clamav.sh causes email duplication
           Product: kmail2
           Version: 4.7
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: NOR
         Component: general
        AssignedTo: kdepim-bugs at kde.org
        ReportedBy: doron.fediuck at gmail.com


Version:           4.7 (using KDE 4.7.3) 
OS:                Linux

Hi,
I'm using the built-in clamav integration.
During migration I had to re-create my dimap account,
since the migration tool failed, and I thought It'll
take a few hours to get all my emails and I'll be up & running.
Then I noticed *all* my email messages
(~1.5 GB, 67,000 messages) are being recognized as
just arrived in the imap server (I'm using dimap).

After some deep diving I also found many messages
were duplicated. When trying to dig in, I saw almost
all messages were added an x-virus header (even if
already had one):

]$ head /home/doronf/.local/share/akonadi/file_db_data/445057_r0
X-Virus-Flag: no
X-Virus-Flag: no
Return-Path: ...

Checking the kmail_clamav.sh I see:
if $CLAMCOMANDO $TEMPFILE | grep -q FOUND; then
    echo "X-Virus-Flag: yes"
else
    echo "X-Virus-Flag: no"
fi

This means that every message gets another header when client-server
are sync'ing, and time stamp is being changed as well (messages from
2009 identified by server as just arrived).

Reproducible: Always

Steps to Reproduce:
Define an account on kmail2 with existing messages on server,
make sure clamav script runs for each maessages you get.

Actual Results:  
The message timestamp is changed on server side,
one ore more X-Virus-Flag header entries are added.

Expected Results:  
Message timestamp should not be changed,
X-Virus-Flag header entry should be limited to one.

Script should be fixed to have something like:

if $CLAMCOMANDO $TEMPFILE | grep -q FOUND; then
    echo "X-Virus-Flag: yes"
else
    grep -q "X-Virus-Flag" $TEMPFILE || echo "X-Virus-Flag: no"
fi

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.