[Bug 251274] multifolder selection ('select') hangs when selecting server folders after pressing 'done'

[András Manţia]

https://bugs.kde.org/show_bug.cgi?id=251274


András Manţia <amantia at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amantia at kde.org




--- Comment #5 from András Manţia <amantia kde org>  2010-09-16 10:31:44 ---
I forgot to update before checking the br, so I debugged into it and came up
with this patch:
Index: itemviews/kselectionproxymodel.cpp
===================================================================
--- itemviews/kselectionproxymodel.cpp  (revision 1175646)
+++ itemviews/kselectionproxymodel.cpp  (working copy)
@@ -191,7 +191,7 @@
         const QModelIndex nextSibling = ansList.value(bestParentRow + 1);

         if (!nextSibling.isValid()) {
-            continue;
+            break;
         }

         if (youngestAncestor.row() <= nextSibling.row()) {


The reasoning of the change is that if nextParent == commonParent at the
beginning and nextSibling is not valid, the loop will never end.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.