[Bug 260265] Cannot retrieve my emails (via POP3) from M$ Exchange Server

[Thomas McGuire]

https://bugs.kde.org/show_bug.cgi?id=260265


Thomas McGuire <mcguire at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Thomas McGuire <mcguire kde org>  2010-12-25 00:02:11 ---
commit 820f3870fbba43358ae6a4f96c04b2153acc041d
branch master
Author: Thomas McGuire <mcguire at kde.org>
Date:   Fri Dec 24 23:37:52 2010 +0100

    Make manual entry of password work again.

    This ceased to work after porting from KIO::Passworddialog to
    KPasswordDialog, since KIO::PasswordDialog stored the login and password
into
    the variables passed by reference in the constructor, while KPasswordDialog
    doesn't do this.

    BUG: 260265

diff --git a/resources/pop3/pop3resource.cpp b/resources/pop3/pop3resource.cpp
index 4398e1e..066c1db 100644
--- a/resources/pop3/pop3resource.cpp
+++ b/resources/pop3/pop3resource.cpp
@@ -192,14 +192,11 @@ void POP3Resource::walletOpenedForSaving( bool success )

 void POP3Resource::showPasswordDialog( const QString &queryText )
 {
-  QString login = Settings::self()->login();
-  bool rememberPassword = Settings::self()->storePassword();
-
   // FIXME: give this a proper parent widget
   KPasswordDialog dlg( 0, KPasswordDialog::ShowUsernameLine |
KPasswordDialog::ShowKeepPassword );
-  dlg.setUsername( login );
+  dlg.setUsername( Settings::self()->login() );
   dlg.setPassword( mPassword );
-  dlg.setKeepPassword( rememberPassword );
+  dlg.setKeepPassword( Settings::self()->storePassword() );
   dlg.setPrompt( queryText );
   dlg.setCaption( name() );
   dlg.addCommentLine( i18n( "Account:" ), name() );
@@ -208,7 +205,8 @@ void POP3Resource::showPasswordDialog( const QString
&queryText )
     cancelSync( i18n( "No username and password supplied." ) );
     return;
   } else {
-    Settings::self()->setLogin( login );
+    mPassword = dlg.password();
+    Settings::self()->setLogin( dlg.username() );
     Settings::self()->writeConfig();
     Settings::self()->setStorePassword( false );
     if ( dlg.keepPassword() ) {

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.