[Bug 254395] pop3 resources switches itself from offline to online if "interval mail checking" is enabled

Thomas McGuire mcguire at kde.org
Fri Dec 24 18:09:09 GMT 2010


https://bugs.kde.org/show_bug.cgi?id=254395


Thomas McGuire <mcguire at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Thomas McGuire <mcguire kde org>  2010-12-24 19:09:08 ---
commit df948b1d213afe403cda62686aa1e2d285b233d9
branch master
Author: Thomas McGuire <mcguire at kde.org>
Date:   Fri Dec 24 19:06:21 2010 +0100

    Don't check mail automatically when the resource is offline.

    BUG: 254395

diff --git a/resources/pop3/pop3resource.cpp b/resources/pop3/pop3resource.cpp
index a285c98..42f3c25 100644
--- a/resources/pop3/pop3resource.cpp
+++ b/resources/pop3/pop3resource.cpp
@@ -83,10 +83,14 @@ void POP3Resource::updateIntervalTimer()

 void POP3Resource::intervalCheckTriggered()
 {
-  kDebug() << "Starting interval mail check.";
   Q_ASSERT( mState == Idle );
-  startMailCheck();
-  mIntervalCheckInProgress = true;
+  if (isOnline()) {
+    kDebug() << "Starting interval mail check.";
+    startMailCheck();
+    mIntervalCheckInProgress = true;
+  } else {
+    mIntervalTimer->start();
+  }
 }

 void POP3Resource::aboutToQuit()

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the Kdepim-bugs mailing list