[Bug 223441] Port, fix and test objecttreeparser

[Thomas McGuire]

https://bugs.kde.org/show_bug.cgi?id=223441





--- Comment #9 from Thomas McGuire <mcguire kde org>  2010-04-18 15:07:38 ---
> 1) Make sure that saving the message as mbox saves the original encrypted 
>    message, not the modified one

Fixed, as the OTP doesn't modify the original message anymore.
mStoredMessagePayload can also be removed again.

> 2) What should happen when deleting/edit an attachment that is part of the 
>    encrypted message? Check what KMail 1 does in this case.

This is buggy in KMail 1, attachment deletion and editing inside of decrypted
nodes does not work. Easiest way around this is to just disable those actions
for those temp nodes.

> 3) Be careful when saving back the message (for some other reason than 
>    deleting/editing attachments), it should save back the original message, 
>    not the modified one

Fixed as well, same reason as 1).

> a) In the viewer, the original encrypted nodes are shown as attachments in 
>    the viewer. Didn't happen in KMail 1.

Fixed according to Andras.

> b) The signature is marked as invalid, even though it is valid

Fixed as well.

> storeDisplayedMessagesUnencrypted().

For all of the store unencrypted message stuff, we discussed that it is
probably best to rewrite objectTreeToDecryptedMsg() and base it on the
temporary nodes createAndParseChildNodes() creates.

> 6) Make sure insertAndParseChildNode() works, and check all if all callers 
>    work. One example are old-style mailman messages, but I think there are more

Old style mailman messages are fixed, and crypto stuff probably as well.

> 7) trueFromAddress() was incorrectly ported

This is fixed now I guess, after processRfc822Subtype was changed. I might need
to double-check this though.

> Right now, createAndParseTempNode() deletes the node after calling
> parseObjectTree() on it.

We decided on store the newly created nodes in the NodeHelper so that the nodes
can be found again when the OTP is run again on the same tree, in async mode.

> The attachment quick list in the fancy header right now does not work 

Probably the easiest way to fix this it to change the AttachmentUrlHander to
take attachments inside of temp nodes into account. This would probably also
fix attachments actions such as save as and others.
It might be an idea to make the mime tree model aware of temp nodes as well,
since we need to be able to see the decrypted nodes in the mime tree viewer.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.