[Bug 223441] Port, fix and test objecttreeparser

Thomas McGuire mcguire at kde.org
Fri Apr 9 12:39:07 BST 2010


https://bugs.kde.org/show_bug.cgi?id=223441





--- Comment #7 from Thomas McGuire <mcguire kde org>  2010-04-09 13:39:04 ---
Adding some notes after a short IRC discussion:

Right now, createAndParseTempNode() deletes the node after calling
parseObjectTree() on it. This means all state attached to the node gets lost,
i.e. the mementos and all the maps in the NodeHelper, like mEncryptionState.
The OTP is called multiple times on the same root node, for async crypto stuff
and also for things like expanded/collapsed quote marks, so the state should
not get lost at all. Probably the temp node should be stored in NodeHelper
instead.

The attachment quick list in the fancy header right now does not work for
attachments in encrypted messages. Same with the mimetree viewer, ideally it
would only show the decrypted parts, and not the original encrypted one, once
it has been decrypted. Clicking on nodes in the mimetree viewer should also
work for stuff inside encrypted nodes.

mStoredMessagePayload can now be removed, and probably also the "processed
source" tab in the source viewer. Or maybe the "processed source" tab should
show the source of the temp nodes.

Note to self: Update the OTP documentation about insertAndParseChildNode, since
it has changed so much now.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the Kdepim-bugs mailing list