[Bug 207296] New Contact, New group and Quick Search actions are preselected by default in the 'Configure Toolbar' dialogue

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=207296





--- Comment #4 from David Faure <faure kde org>  2009-09-22 20:43:31 ---
Created an attachment (id=37114)
 --> (http://bugs.kde.org/attachment.cgi?id=37114)
proposed fix

For review and/or archiving purposes: here's the suggested fix (modifying the
XML on startup and after toolbar editing). Requires the kdelibs patch in
http://reviewboard.kde.org/r/1694.

The problem is that if the user adds "New Contact" explicitely, the code will
remove it again. Maybe we should have <Action name="akonadi_contact_create"
remove_in_kontact="true"/> in kaddressbookui.rc, so that we only remove the
default actions and not the ones added by the user. This would replace
invisibleToolbarActions().

I also wonder what happens when editing toolbars in kontact and then using
kaddressbook standalone -- the actions will be missing, since the local ui.rc
file will not contain the actions anymore. Argh. Seems the only clean solution
is to have two ui.rc files, either in the sources (duplication) or at runtime
(making a local copy with the actions removed, and using that for the
kaddressbook part in kontact...)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.