[Bug 207297] 'Delete Address Book' button cannot be added from the 'Configure Toolbars' dialogue.

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=207297





--- Comment #3 from David Faure <faure kde org>  2009-10-10 01:01:44 ---
Created an attachment (id=37480)
 --> (http://bugs.kde.org/attachment.cgi?id=37480)
proposed fix

Tobias: this is because of the use of QAction::setVisible in
standardcontactactionmanager.cpp. It makes the actions appear and disappear,
which is quite unexpected I think, it would be better to just enable/disable
them. In fact the attached patch works ok for me.

I guess the only difference is that the Edit menu looks a bit more "crowded"
because it contains "Delete Addressbook" at all times. But I think GUI
styleguides say that it's better to disable actions than to have them disappear
altogether.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.