[Bug 182208] messages passed through a pipe does not get updated in the main window

Thomas McGuire mcguire at kde.org
Fri Mar 20 14:21:54 GMT 2009


https://bugs.kde.org/show_bug.cgi?id=182208





--- Comment #9 from Thomas McGuire <mcguire kde org>  2009-03-20 15:21:52 ---
Hi Matthias,

great work figuring those things out! The filter stuff certainly belongs to the
more complicated parts of KMail.
I'll attach a patch which contains all your points (your patch only had one
point in it).

Please test it on your side and see if everything works as expected. Once done,
send it to reviewboard.kde.org, see
http://techbase.kde.org/index.php?title=Contribute/Send_Patches&action=submit.
(other devs will probably also want to have a look at the patch)

To 1: Good catch. I guess this is a result of Qt3 -> Qt4 porting. For some
reason, the PipeJob redeclared done() as a public virtual method, while in the
base class (ThreadWeaver::Job), it was a non-virtual signal. Strange. I've
fixed that, see the attached patch.

To 2: I'm a bit concerned that this might introduce regressions for POP3 users,
since they'll suddenly switch from KMFilterMgr to ActionScheduler. But we have
to fix those regressions then, so the fix is OK.

To 3: Added a new property to the ActionScheduler: ignoreFilterSet. That does
the trick.

To 4: Interesting. Which spam filter actually removes that header?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the Kdepim-bugs mailing list