[Bug 218253] knode hangs on XOVER error

Olivier Trichet nive at nivalis.org
Mon Dec 14 22:18:02 GMT 2009


https://bugs.kde.org/show_bug.cgi?id=218253





--- Comment #4 from Olivier Trichet <nive nivalis org>  2009-12-14 23:18:01 ---
SVN commit 1062490 by otrichet:

kio_nntp could send a broken XOVER request to the server and hang on an error
answer.
This corrects the broken request.

Thanks to Arkadiusz Miskiewicz for the analysis.

Arkadiusz, I change your patch because the real integer overflow is in the
test "lastSerNum - first > max". Because lastSerNum and first are
"unsigned long", when "lastSerNum" is inferior to "first", the
computation of "lastSerNum - first" overflow and give a big long and as
a consequence the test succeeds.

CCBUG: 218253

 M  +5 -0      nntp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1062490

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the Kdepim-bugs mailing list