[Bug 161615] New: mail viewer: "From:" header suppresses email address in "long" mode

[Melchior Franz]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161615         
           Summary: mail viewer: "From:" header suppresses email address in
                    "long" mode
           Product: kmail
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: kdepim-bugs kde org
        ReportedBy: mfranz kde org


Version:           svn/head 3.* branch as of today (2008/05/04) (using KDE 3.5.9)
Installed from:    Compiled From Sources
Compiler:          gcc (GCC) 4.2.1 (SUSE Linux) libc 2.6.1 (20070803)
OS:                Linux

In today's kmail (SVN/HEAD 3.* branch) the "long" header shows only the sender's name, but suppresses the email address. This used to work for years and must have been broken in the last weeks. The arguments to KMMessage::emailAddrAsAnchor() are apparently set wrongly. (The same fix may also be necessary elsewhere.)

$ svn diff
Index: headerstyle.cpp
===================================================================
--- headerstyle.cpp     (revision 803929)
+++ headerstyle.cpp     (working copy)
 @ -290,7 +290,7  @
       if ( fromStr.isEmpty() ) // no valid email in from, maybe just a name
         fromStr = message->fromStrip(); // let's use that
       headerStr.append(i18n("From: ") +
-          KMMessage::emailAddrAsAnchor( fromStr, "", false) );
+          KMMessage::emailAddrAsAnchor( fromStr, false, "", true ) );
       if ( !vCardName.isEmpty() )
         headerStr.append("  <a href=\"" + vCardName +
               "\">" + i18n("[vCard]") + "</a>" );