[Bug 151916] [PATCH]dimap folder uploads status of all messages on sync

[Tobias Niwi]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=151916         




------- Additional Comments From niwi-hh gmx de  2008-01-27 00:33 -------
I have written earlier today about my problems to install the patch in comment#2. I think I finally succeeded in installing the patch but now I get an error message while compiling the patched source code. Since I don't know if I patched the source code the right way I can't say for sure if this is a problem caused by the patch or me. But what I can say for sure, is that the error is not caused by the source code or the way I try to compile it. I have no problems to compile the unpatched source code.

Here is what I did:
1. Because the header information for kmfoldercachedimap.cpp and kmfoldercachedimap.h in the patch seem to be hard coded for a portage system I removed them and split the patch in two files. Each splitted part included the information for one of two mentioned files to patch.

2. Then I installed the patches with:
# patch ~/kdepim-3.5.8/kmail/kmfoldercachedimap.cpp ~/patch1.diff'
# patch ~/kdepim-3.5.8/kmail/kmfoldercachedimap.h ~/patch2.diff

With patch 1 (for kmfoldercachedimap.cpp) I got the following error messages:

missing header for unified diff at line 1 of patch
patching file /home/niwi/Werkstatt/kdepim-3.5.8/kmail/kmfoldercachedimap.cpp
Hunk #1 succeeded at 189 (offset 9 lines).
Hunk #2 succeeded at 277 (offset 12 lines).
Hunk #3 FAILED at 857.
Hunk #4 succeeded at 1430 (offset 47 lines).
Hunk #5 succeeded at 1531 (offset 92 lines).
patch unexpectedly ends in middle of line
Hunk #6 succeeded at 1843 with fuzz 1 (offset 110 lines).
1 out of 6 hunks FAILED -- saving rejects to file /home/niwi/Werkstatt/kdepim-3.5.8/kmail/kmfoldercachedimap.cpp.rej

I patched hunk #3 manually. The reason for the problem is a missing ")" in line 29,80 of the patch. I checked hunk #5 and 6 and they got patched correctly.

After I installed the patches I did a successful './configure' and started 'make'. 

Here is the error message I finally got:

kmfoldercachedimap.cpp: In member function 'void KMFolderCachedImap::rememberDel                       etion(int)':
kmfoldercachedimap.cpp:495: warning: comparison of unsigned expression >= 0 is a                       lways true
kmfoldercachedimap.cpp: In member function 'void KMFolderCachedImap::serverSyncI                       nternal()':
kmfoldercachedimap.cpp:897: error: could not convert '((KMFolderCachedImap*)this                       )->KMFolderCachedImap::mStatusChangedLocally' to 'bool'
make[3]: *** [kmfoldercachedimap.lo] Error 1
make[3]: Leaving directory `/home/niwi/Werkstatt/kdepim-3.5.8/kmail'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/niwi/Werkstatt/kdepim-3.5.8/kmail'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/niwi/Werkstatt/kdepim-3.5.8'
make: *** [all] Error 2


I guess there is a problem with the patch (or me...?).

Any idea what I could do?