[Bug 153904] [PATCH] MDN not asked on deleting mail
Marc Mutz
mutz at kde.org
Mon Feb 18 09:15:00 GMT 2008
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.kde.org/show_bug.cgi?id=153904
mutz kde org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|kdepim-bugs kde org |mutz kde org
------- Additional Comments From mutz kde org 2008-02-18 10:14 -------
> As I understand KMMessage::createMDN right, it's even worse: if it is said to
> ignore (what should be mode = 0?) and it is AutomaticAction, it is send too,
> instead of ignored....
That is not correct. 'Ignored' is handled near the beginning, of course:
> // default:
> int mode = mdnConfig.readEntry( "default-policy", 0 );
> if ( !mode || mode < 0 || mode > 3 ) {
> // early out for ignore:
> setMDNSentState( KMMsgMDNIgnore );
> return 0;
> }
As for your patch, please send minimal patches. Use the -bB options to diff, e.g. That said, I see no reason, indeed, to not ask the user on automatic actions if he indicated he wants to be asked. Your solution to never send an MDN for mode == Ask && automatic action is wrong, though. It might very well be that no-one calls createMDN() with a == AutomaticAction and allowGUI == true. But this case nevertheless needs to be handled.
I've attached a new patch. Please check whether it fixes your problem.
More information about the Kdepim-bugs
mailing list