[Bug 168544] local inbox is not shown when starting with clean install

[Jonathan Marten]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=168544         
jjm keelhaul me uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|KMail does not show the     |local inbox is not shown
                   |local inbox                 |when starting with clean
                   |                            |install



------- Additional Comments From jjm keelhaul me uk  2008-08-07 13:25 -------
Nothing to do with the index files, they are created correctly.

The problem stems from commit 702414, "don't initialize favorite folder view with hidden/unused inboxes" - if the inbox is empty and has no accounts associated with it then it is hidden.  This is intended behaviour.

Unfortunately the folder list is not updated if a new account is added that delivers to the inbox, although it does happens when a new message arrives.  This can be taken care of with:

  connect(kmkernel->acctMgr(), SIGNAL(accountAdded(KMAccount *)),
          this, SLOT(slotUnhideLocalInbox()));

in KMFolderTree::connectSignals().  There is a further complication in that when this signal happens, the account's destination folder has not had the account added to it so the inbox still does not appear (the last test in FolderTreeBase::hideLocalInbox() fails).  This can be fixed by doing:

    KMFolder *folder = account->folder();
    if ( folder && !folder->hasAccounts() ) account->setFolder( folder, true );

in AccountManager::add(KMAccount *account).

Not sure if the above has any unwanted side effects, but have tested the changes and they seem to work.