[Bug 158861] crash on renaming open folder in imap

Thomas McGuire Thomas.McGuire at gmx.net
Mon Apr 14 20:49:11 CEST 2008


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158861         
Thomas.McGuire gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From Thomas.McGuire gmx net  2008-04-14 20:49 -------
SVN commit 797025 by tmcguire:

Fix totally broken renaming of online IMAP folders:

- emit the closed() signal before calling folderMgr()->contentsChanged()
  This fixes an refcount assert when calculating the unread count.
  The assert would trigger there because the folder is closed with refcount 0
  but still selected. Now, the headerview will open the folder before that, making
  the refount 1.

- Don't show an error message when the old folder couldn't be unsubscribed. That error
  message doesn't make sense, since the old folder does not exist anymore, and therefore
  can't be unsubscribed anyway.

- Let the mainwidget re-open the folder after it is renamed. This fixes an assert when 
  switching away from an renamed folder, which would close it despite not having called open()
  before.

- Also change the objectname when renaming, now renaming the same folder more than once works.

- tabs--

BUG: 158861


 M  +1 -1      folderstorage.cpp  
 M  +1 -1      imapaccountbase.cpp  
 M  +1 -1      kmfoldermgr.cpp  
 M  +18 -0     kmmainwidget.cpp  
 M  +5 -0      kmmainwidget.h  
 M  +1 -0      renamejob.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=797025


More information about the Kdepim-bugs mailing list