[Bug 16480] [PATCH] Insert signature at top or cursor

[Scott]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=16480         
firebrnr gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22013|0                           |1
        is obsolete|                            |



------- Additional Comments From firebrnr gmail com  2007-11-13 18:09 -------
Created an attachment (id=22048)
 --> (http://bugs.kde.org/attachment.cgi?id=22048&action=view)
trunk-tofu.patch

Finally a new patch update!  Tested against svn revision 736182.  I fixed a few
extra bugs on the way:
1) clean spaces didn't delete original text, just inserted new text
2) clean spaces required two undos to get to previous text (now only one)
3) clean spaces didn't respect sig text for the profile initially used in a
compose window

At this point my biggest concern is implementation; with prepending rather than
appending we don't know where the signature is anymore, so we have to guess; if
the user edits the signature in the email or writes a new one above it (what if
they have a really simple signature, like their name, and don't add the -- ?),
we'll guess wrong (mainly when switching identities) and it will be perceived
as an interface problem.

I think this is a generally good implementation and the wrong guess cases
should be very rare, but I'm going to continue to think about it and do some
experimentation.

The best option may be to add %SIGNATURE as a template option and that I'm
going to look into, but not in this patch.