[Bug 149002] [PATCH] Support for showing popfile headers in fancy headers

Thomas McGuire Thomas.McGuire at gmx.net
Wed Aug 22 12:10:49 BST 2007


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149002         
Thomas.McGuire gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |messageviewer
            Summary|support for showing popfile |[PATCH] Support for showing
                   |headers in fancy headers    |popfile headers in fancy
                   |                            |headers



------- Additional Comments From Thomas.McGuire gmx net  2007-08-22 13:10 -------
Ok, some things about the patch:

1.
Adding features to the 3.5 branch is no longer allowed, please port your patch to KDE 4.

2.

If someone who uses popfile responses to someone who does not use it, the receiver still has the popfile headers in the mail, right? If the receiver uses KMail, he sees the popfile headers even though he does not use popfile himself, therefore I think using the existing config option is not OK. An other one has to be added.

3. 
Don't use tabs. Use spaces instead.

4.
Please adhere to the KMail coding style, especially with regard to spaces around parenthesis.

Other than that, the patch seems fine, although I haven't tried it.
Can you please attach an example mail which has these headers?



More information about the Kdepim-bugs mailing list