Patches to fix race conditions in auto-alignment feature

Fri May 5 13:44:20 UTC 2017

HI

2017-05-05 10:39 GMT-03:00 Nicolas Carion <carion.nicolas at gmail.com>:

> @farid this is a different patch
>

Ooops =)

> @raphael, I'll be taking care of this ASAP, probably in the course of next
> week. I also have to port it to the new branch
>

Thanks

Raphael, we are having our Café soon in case you'd like to participate.

https://dudle.inf.tu-dresden.de/kedenlivecafe17and18/

Cheers :)

>
> Le 5 mai 2017 15:33, "farid abdelnour" <snd.noise at gmail.com> a écrit :
>
>> Salut Raphael
>>
>> It seems your bug has been committed:
>>
>> https://cgit.kde.org/kdenlive.git/commit/?h=Applications/17.
>> 04&id=3404da90de3ce10377cbebaaf5abc9229f1ce43f
>>
>> Thanks for your contribution and let us know if we can help you somehow
>> for further involvement in the project.
>>
>> Cheers!
>>
>> 2017-04-30 15:28 GMT-03:00 Raphaël Marinier <raphael.marinier at gmail.com>:
>>
>>> Could someone (maybe alcinos?) finish the review of
>>> https://phabricator.kde.org/D5453, which fixes a race condition in the
>>> auto-alignment feature?
>>>
>>> Thanks!
>>>
>>>
>>> On Sat, Apr 15, 2017 at 2:58 PM, farid abdelnour <snd.noise at gmail.com>
>>> wrote:
>>> > Greetings
>>> >
>>> > 2017-04-14 17:08 GMT-03:00 Raphaël Marinier <
>>> raphael.marinier at gmail.com>:
>>> >>
>>> >> Thanks for the warm welcome.
>>> >
>>> >
>>> > Happy to have you here.
>>> >
>>> >>
>>> >> I posted the patches to phabricator as advised.
>>> >
>>> >
>>> > Perfect.
>>> >
>>> >>
>>> >> My patch is not a response to the March status update, but I read it
>>> >> and it was good to see that the project was actively being developed
>>> >> and to get an idea where it's heading.
>>> >>
>>> >> I could offer some help to develop Kdenlive, e.g. starting with fixing
>>> >> bugs or adding small features. At this point, I would not commit to
>>> >> the bigger tasks mentioned in the status update.
>>> >
>>> >
>>> > We have a list of low hanging bugs [1] if you'd like to cherry pick
>>> one.
>>> > Avoid timeline related issues since those will go away after the
>>> > refactoring. But feel free to also browse through the bug tracker or
>>> > phabricator's feature proposals [2][3][4] in case you find something
>>> more
>>> > interesting to work on.
>>> >
>>> >>
>>> >> Raphael
>>> >
>>> >
>>> > Happy hacking
>>> >
>>> > [1]
>>> > https://bugs.kde.org/buglist.cgi?quicksearch=product%3Akdenl
>>> ive%20flag%3Alow_hanging&list_id=1434110
>>> > [2] https://phabricator.kde.org/T3020
>>> > [3] https://phabricator.kde.org/T2336
>>> > [4] https://phabricator.kde.org/T5434
>>> >
>>> >>
>>> >>
>>> >> On Fri, Apr 14, 2017 at 4:50 PM, farid abdelnour <snd.noise at gmail.com
>>> >
>>> >> wrote:
>>> >> > Hi Raphaël,
>>> >> >
>>> >> > Welcome to the community!
>>> >> >
>>> >> > Is your patch a response to the recent post we published [1] or did
>>> you
>>> >> > get
>>> >> > here by other means?
>>> >> >
>>> >> > Over at phabricator you'll also be able to get a glimpse of the
>>> >> > refactoring
>>> >> > work being made, exiting times coming to Kdenlive.
>>> >> >
>>> >> > [1] https://kdenlive.org/2017/03/kdenlive-status-update/
>>> >> >
>>> >> > Thanks for the contribution :)
>>> >> >
>>> >> > Cheers
>>> >> >
>>> >> > 2017-04-14 6:55 GMT-03:00 alcinos <french.ebook.lover at gmail.com>:
>>> >> >>
>>> >> >> Hi Raphaël,
>>> >> >>
>>> >> >> Thank you for your contribution! Your PR looks good to me so far.
>>> >> >>
>>> >> >> Please note however that KDE (and thus Kdenlive) uses Phabricator
>>> for
>>> >> >> the
>>> >> >> review and merge process (github is only a mirror). Would it be
>>> >> >> possible for
>>> >> >> you to submit it there? (How to:
>>> >> >> https://community.kde.org/Infrastructure/Phabricator#Posting
>>> _a_Patch,
>>> >> >> link
>>> >> >> to the phabricator: https://phabricator.kde.org/)
>>> >> >> You can set mardelle and alcinos as reviewers.
>>> >> >>
>>> >> >> Cheers,
>>> >> >>
>>> >> >> alcinos
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >> 2017-04-13 23:23 GMT+02:00 Raphaël Marinier
>>> >> >> <raphael.marinier at gmail.com>:
>>> >> >>>
>>> >> >>> Hi all,
>>> >> >>>
>>> >> >>> I am a new user of kdenlive, and noticed arbitrary alignment of
>>> tracks
>>> >> >>> from time to time when using the auto alignment feature.
>>> >> >>> I investigated and found one race condition (and a couple of
>>> smaller
>>> >> >>> issues). I propose a fix with pull request
>>> >> >>> https://github.com/KDE/kdenlive/pull/6.
>>> >> >>>
>>> >> >>> Please have a look and tell me what you think,
>>> >> >>>
>>> >> >>> Thanks,
>>> >> >>>
>>> >> >>> Raphael M.
>>> >> >>
>>> >> >>
>>> >> >
>>> >> >
>>> >> >
>>> >> > --
>>> >> > 1111.1010.r.i.1101|n.o.i.s.1110|i.m.1010.g.1110|مقاومة
>>> >> > fsf member #5439
>>> >> > usuario GNU/Linux #471966
>>> >> > |_|0|_|
>>> >> > |_|_|0|
>>> >> > |0|0|0|
>>> >> > <a href="http://www.gunga.com.br">gunga</a>
>>> >> > <a href="http://www.tempoecoarte.com.br">tempoecoarte</a>
>>> >> > <a href="http://www.atelier-labs.org">atelier-labs</a>
>>> >> > <a href="http://www.mocambos.net">rede mocambos</a>
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > 1111.1010.r.i.1101|n.o.i.s.1110|i.m.1010.g.1110|مقاومة
>>> > fsf member #5439
>>> > usuario GNU/Linux #471966
>>> > |_|0|_|
>>> > |_|_|0|
>>> > |0|0|0|
>>> > <a href="http://www.gunga.com.br">gunga</a>
>>> > <a href="http://www.tempoecoarte.com.br">tempoecoarte</a>
>>> > <a href="http://www.atelier-labs.org">atelier-labs</a>
>>> > <a href="http://www.mocambos.net">rede mocambos</a>
>>>
>>
>>
>>
>> --
>> 1111.1010.r.i.1101|n.o.i.s.1110|i.m.1010.g.1110|مقاومة
>> fsf member #5439
>> usuario GNU/Linux #471966
>> |_|0|_|
>> |_|_|0|
>> |0|0|0|
>> <a href="http://www.gunga.com.br">gunga</a>
>> <a href="http://www.tempoecoarte.com.br">tempoecoarte</a>
>> <a href="http://www.atelier-labs.org">atelier-labs</a>
>> <a href="http://www.mocambos.net">rede mocambos</a>
>>
>

-- 
1111.1010.r.i.1101|n.o.i.s.1110|i.m.1010.g.1110|مقاومة
fsf member #5439
usuario GNU/Linux #471966
|_|0|_|
|_|_|0|
|0|0|0|
<a href="http://www.gunga.com.br">gunga</a>
<a href="http://www.tempoecoarte.com.br">tempoecoarte</a>
<a href="http://www.atelier-labs.org">atelier-labs</a>
<a href="http://www.mocambos.net">rede mocambos</a>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20170505/a653e9fb/attachment-0001.html>