Review Request 128923: Deselect -- as opposite to Select All

Jean-Baptiste Mardelle jb at kdenlive.org
Thu Sep 15 19:09:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128923/#review99224
-----------------------------------------------------------




src/timeline/customtrackview.cpp (line 7762)
<https://git.reviewboard.kde.org/r/128923/#comment66812>

    For that task, it is better to use CustomTrackView's existing method clearSelection()
    
    This ensures the effect settings is cleared and a few other things.


- Jean-Baptiste Mardelle


On Sept. 15, 2016, 6:06 p.m., The DiveO wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128923/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 6:06 p.m.)
> 
> 
> Review request for Kdenlive.
> 
> 
> Repository: kdenlive
> 
> 
> Description
> -------
> 
> This patch implements the missing action "deselect" as the opposite of "select all" for the timeline. Similar to selectAll it is wired up to the default deselect action in KF5. This allows users to assign a keyboard shortcut; please note that the default KF5 shortcut for this is Shift+Ctrl+A.
> 
> 
> Diffs
> -----
> 
>   src/kdenliveui.rc 7543d5d 
>   src/mainwindow.h 95629ae 
>   src/mainwindow.cpp a9b4c2f 
>   src/timeline/customtrackview.h 3b9e4d0 
>   src/timeline/customtrackview.cpp 5f377c3 
> 
> Diff: https://git.reviewboard.kde.org/r/128923/diff/
> 
> 
> Testing
> -------
> 
> Tested on recent Kdenlive git master on Kubuntu 16.04LTS with recent KF5 and Qt updates installed.
> 
> 
> Thanks,
> 
> The DiveO
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20160915/853f939a/attachment.html>


More information about the kdenlive mailing list