Review Request 129270: Moving DragValue class and create base type for parameter widgets

alcinos alcinos french.ebook.lover at gmail.com
Thu Oct 27 23:03:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129270/
-----------------------------------------------------------

Review request for Kdenlive.


Repository: kdenlive


Description
-------

This is a first step towards a refactoring of the effects stack. Currently the different widgets do not share a base class and their creation based on the xml is a bit cluttered, with a lot of redundancies. The plan is to unify this by creating a proper factory method.

I'll split the work into small and hopefully easy to review bits so that we make sure that no feature is lost on the way.
In this diff, I only make DoubleParameterWidget a subclass of AbstractParameterWidget


Diffs
-----

  src/effectstack/CMakeLists.txt 80ae0d6 
  src/effectstack/parametercontainer.h 3b1b1b3 
  src/effectstack/parametercontainer.cpp ccec798 
  src/effectstack/widgets/abstractparamwidget.h PRE-CREATION 
  src/effectstack/widgets/doubleparameterwidget.h 7c81a2e 
  src/effectstack/widgets/doubleparameterwidget.cpp bf7f245 
  src/effectstack/widgets/draggablelabel.h PRE-CREATION 
  src/effectstack/widgets/draggablelabel.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129270/diff/


Testing
-------

Tested with a mock project


Thanks,

alcinos alcinos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20161027/d1872ceb/attachment.html>


More information about the kdenlive mailing list