[kdenlive] R: Apologies and explanations

Mon May 30 20:29:14 UTC 2016

If I'm not wrong, the only people who reported having faced the problem are Farid and Jesse (over bugtracker/list/forum)...
And none of them deplored important data loss (just some time to recover the backups in case kdenlive was running from the main user account).
So don't feel too guilty, you didn't harm anybody thanks to your quick reaction!
I'll take a btrfs snapshot everytime before starting the program from now on ;-)

Cheers,

Vincent

Le lundi 30 mai 2016, 17:00:07 CEST farid abdelnour a écrit :

Hi JB,

First of all thank you for all your hard work making it possible to do our jobs with free software! You are making the world a better place!

As you said, lets move forward making a better kdenlive. 

Cheers :D

2016-05-30 13:27 GMT-03:00 Harald Albrecht <harald.albrecht at gmx.net[1]>:

Jean-Baptiste, Massimo,

I can only second what Massimo said!

Thank you very, very much for your tremendous work on Kdenlive!

Harald

maxstar at tin.it[2]> Datum: 30.05.2016 11:33 (GMT+01:00) An: jb at kdenlive.org[3], kdenlive at kde.org[4] Betreff: [kdenlive] R: Apologies and explanations 

jb at kdenlive.org[3]
kdenlive at kde.org[4]>Ogg: [kdenlive] Apologies and explanations

Hi all,

As you might know, a recent bug in Kdenlive's git master caused major data loss to some users. I am deeply sorry about it and would like to provide some details about what happened, why and what we did and plan about it.

1- what happened:

In Kdenlive, we sometimes manage a lot of temporary data. As I was working on a new feature (timeline preview), it generated lots of temporary rendered videos. So at some point, this data needs to be deleted. To do this, I used a standard Qt class, QDir. However, if for some reason QDir is not correctly initialized or an operation fails, it defaults to your home directory. You can guess the end. As with many bugs, the error did not trigger everytime, so when I tried it before committing, I did not realize the possible problem.

2 - how could such stupid code be committed:

One of the reason it was committed is that I have been working too much in the last weeks. Working on Kdenlive is great, but at some point I went too far. Combined with my day job, I did not sleep enough and committed this stupid mistake. 

3 - what about the future, is it safe to use Kdenlive ?

As soon as I realized the extend of the problem, I commented out the problematic code and deleted the PPA packages. Git master is safe now, as is current kdenlive-master PPA built from the 26th of May :kdenlive - 4:16.07.70+git201605260633~ubuntu16.04.1

Causing data loss on our users deeply affected me, and I think it should also be a big reminder for everyone that using a daily built development version from git is not safe, and that you must backup your data!

I will put a big warning now on the development version, and will discuss with Vincent about possible changes in our PPA/development policy to help prevent such problems.

I will also of course revise our temporary data handling to make sure such a mistake does not happen twice.

So again, I send my sincere apologies and hope we can continue to move forward in the next months.

_______________________________________________kdenlive mailing list

_kdenlive at kde.org_
https://mail.kde.org/mailman/listinfo/kdenlive[5]

kdenlive at kde.org[4]
https://mail.kde.org/mailman/listinfo/kdenlive[5]

-- 

1111.1010.r.i.1101|n.o.i.s.1110|i.m.1010.g.1110|مقاومةfsf member #5439usuario GNU/Linux #471966|_|0|_||_|_|0||0|0|0|<a href="http://www.gunga.com.br[6]">gunga</a><a href="http://www.tempoecoarte.com.br[7]">tempoecoarte</a>
<a href="http://www.atelier-labs.org[8]">atelier-labs</a>
<a href="http://www.mocambos.net[9]">rede mocambos</a>

--------
[1] mailto:harald.albrecht at gmx.net
[2] mailto:maxstar at tin.it
[3] mailto:jb at kdenlive.org
[4] mailto:kdenlive at kde.org
[5] https://mail.kde.org/mailman/listinfo/kdenlive
[6] http://www.gunga.com.br
[7] http://www.tempoecoarte.com.br
[8] http://www.atelier-labs.org
[9] http://www.mocambos.net
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20160530/87d8fb3c/attachment-0001.html>