[kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

[Roger Morton]

I have uploaded a patch file to the review board. However, it is up there
as just a file attachement - not a diff file.
Why? This happened last time too.


git format-patch -2 HEAD -o ~/development/kdenlive/f
^^^ this gave me 2 patch files. One which did have the new stuff I wrote
 on top of my other new stuff. And this is the file I have uploaded.
If however you try and upload this as a diff file the review board website
 says
"The uploaded diff uses short revisions, but Review Board requires full
revisions."

but
 git format-patch -2 HEAD --full-index -o ~/development/kdenlive/
produces a file that the review board web site is unable to parse.

But hopefully you can get the attachment  and apply it.

On Wed, Jan 20, 2016 at 9:28 PM, Jean-Baptiste Mardelle <jb at kdenlive.org>
wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126796/
>
> Thanks for this patch. Some comments / questions:
> Some files are missing a license header
> The token is saved in $HOME/config/kde.org/kdenlive.conf is that a standard location for saving web tokens ?
>
>
> src/utils/freesound.cpp
> <https://git.reviewboard.kde.org/r/126796/diff/1/?file=434205#file434205line317> (Diff
> revision 1)
>
> 310
>
>         m_previewProcess->start(KdenliveSettings::ffplaypath() + " " +  url  + " -nodisp -autoexit");
>
> I'd prefer if you keep the previous format, calling start with:
>
> m_previewProcess->start(app, parameters);
>
> Seems more secure to me, especially if the url arg is comming from an unsecure source... I am not sure how Qt handles the situation if the url is like;
>
> "http://test.org;rm -Rf *"
>
>
> - Jean-Baptiste Mardelle
>
> On janvier 18th, 2016, 1:54 après-midi UTC, Roger Morton wrote:
> Review request for Kdenlive and Vincent Pinon.
> By Roger Morton.
>
> *Updated jan. 18, 2016, 1:54 après-midi*
> *Repository: * kdenlive
> Description
>
> online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)
>
> Testing
>
> Built. Tested file downloads from freesound. Auhenticates to freesound. keeps authenticated until you delete $HOME/.config/kde.org/kdenlive.conf
> Archive.org video search is now working. Display animiated .gif as the preview file from Archive.org videos.
> No longer have to click search button twice to get it to do the search the first time it runs
> Option to not use personal freesound account and just use HQ preview file instead.
> Downloads low quality preview file in background and does not notify you of it finishing.
>
> Diffs
>
>    - src/CMakeLists.txt (87d29d2)
>    - src/qt-oauth-lib/logindialog.h (PRE-CREATION)
>    - src/qt-oauth-lib/logindialog.cpp (PRE-CREATION)
>    - src/qt-oauth-lib/oauth2.h (PRE-CREATION)
>    - src/qt-oauth-lib/oauth2.cpp (PRE-CREATION)
>    - src/ui/freesound_ui.ui (55a453d)
>    - src/utils/abstractservice.h (0a6a4a7)
>    - src/utils/archiveorg.h (5cdc84f)
>    - src/utils/archiveorg.cpp (1be4d6f)
>    - src/utils/freesound.h (f72d145)
>    - src/utils/freesound.cpp (932c47f)
>    - src/utils/openclipart.h (7a4df1e)
>    - src/utils/openclipart.cpp (adbba68)
>    - src/utils/resourcewidget.h (c171e3c)
>    - src/utils/resourcewidget.cpp (6453f7f)
>
> View Diff <https://git.reviewboard.kde.org/r/126796/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20160204/7be8344b/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-move-token-storage-in-freesound-to-settings-file.patch
Type: text/x-patch
Size: 22242 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20160204/7be8344b/attachment-0001.bin>