[kdenlive] Review Request 125708: Applications/15.08: fix clipping of audio signal view db marks

The DiveO thediveo at gmx.eu
Thu Oct 22 19:32:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125708/
-----------------------------------------------------------

(Updated Oct. 22, 2015, 7:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Kdenlive and Vincent Pinon.


Changes
-------

Submitted with commit de50989848eecf63cf2247c591d02dd6f33cf383 by Vincent Pinon on behalf of Harald Albrecht to branch Applications/15.08.


Repository: kdenlive


Description
-------

In vertical mode the audio signal view clips some of its audio level marks. The reason is that the drawing method does not take into consideration the actual font/text dimensions. This proposed patch fixes the incorrect clipping for vertical mode, that is, when the audio signal view is taller than wide. It calculates the actual width of the longest db level mark, which it assumes to be the last mark in the db level list, instead of using the present hardcoded "fudge" values.


Diffs
-----

  src/scopes/audioscopes/audiosignal.cpp 1830a50 

Diff: https://git.reviewboard.kde.org/r/125708/diff/


Testing
-------

On Kdenlive Applications/15.08 branch on Kubuntu 15.04 64bit installation.


Thanks,

The DiveO

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20151022/168fd7a9/attachment.html>


More information about the kdenlive mailing list