[kdenlive] Review Request 125520: Fix for media controller events not being lost because they get send to NULL parent

The DiveO thediveo at gmx.eu
Sun Oct 4 19:35:27 UTC 2015



> On Okt. 4, 2015, 6:33 nachm., Jean-Baptiste Mardelle wrote:
> > Ship It!

How do I ship, that is, get the diff committed?


- The


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125520/#review86348
-----------------------------------------------------------


On Okt. 4, 2015, 6:20 nachm., The DiveO wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125520/
> -----------------------------------------------------------
> 
> (Updated Okt. 4, 2015, 6:20 nachm.)
> 
> 
> Review request for Kdenlive.
> 
> 
> Repository: kdenlive
> 
> 
> Description
> -------
> 
> Fix for media controller events not being lost because they get send to NULL parent: m_shuttleProcess instance needs to be initialized with "this" as its parent, instead of parent of JogShuttle object.
> 
> 
> Diffs
> -----
> 
>   src/jogshuttle/jogshuttle.cpp 817c9ac 
> 
> Diff: https://git.reviewboard.kde.org/r/125520/diff/
> 
> 
> Testing
> -------
> 
> Yes; using a ShuttlePRO v2 media controller on Kdenlive Applications/15.08 branch.
> 
> 
> Thanks,
> 
> The DiveO
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20151004/2ac1a35e/attachment.html>


More information about the kdenlive mailing list