[kdenlive] Fwd: [mlt] Add a preferred-width attribute to kdenlivetitle text content properties (#78)

[Dan Dennedy]

Please review and let me know if you approve this.

---------- Forwarded message ---------
From: Orhan Kavrakoğlu <notifications at github.com>
Date: Mon, Jun 1, 2015 at 4:55 AM
Subject: [mlt] Add a preferred-width attribute to kdenlivetitle text
content properties (#78)
To: mltframework/mlt <mlt at noreply.github.com>


Would you be interested in such a solution for centered text? It's a
requested feature:

https://kdenlive.org/forum/title-template-aligning-doesnt-work
https://kdenlive.org/forum/center-align-template-title
https://kdenlive.org/forum/template-documentation

The current implementation sets the preferred width to be the text item's
actual width (src/modules/qt/kdenlivetitle_wrapper.cpp:229), making center-
and right-alignment meaningless unless the text is multiline. (When it *is*
multiline, it merely aligns shorter lines according to the longest one)

With this change, you can set preferred-width="x" and it will act as though
the text item had that width. Set x to the video's width and you can have
perfectly centered (or right-aligned) titles.
------------------------------
You can view, comment on, or merge this pull request online at:

  https://github.com/mltframework/mlt/pull/78
Commit Summary

   - Add a preferred-width attribute to kdenlivetitle text content
   properties so we can actually center text

File Changes

   - *M* src/modules/qt/kdenlivetitle_wrapper.cpp
   <https://github.com/mltframework/mlt/pull/78/files#diff-0> (4)

Patch Links:

   - https://github.com/mltframework/mlt/pull/78.patch
   - https://github.com/mltframework/mlt/pull/78.diff

—
Reply to this email directly or view it on GitHub
<https://github.com/mltframework/mlt/pull/78>.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20150601/2fb6bd1d/attachment.html>