[Kdenlive-devel] Please restore pre-0.9.10 fade on AV tracks

[Evert Vorster]

Hi there...

I am not talking for the developers, but I used to complain about just
this thing.

However, there is an option to let kdenlive split audio from video
automatically.
I just added another audio track, and these days I actually edit video
faster, and I have come to depend on the current behaviour in
kdenlive, and prefer it now.

The previous behavior ( the you want ) is counter-intuitive, as you
are doing an audio transformation on a video track.

It may not be what you want to hear, but I think the chances of your
patch being applied upstream are slim.

Kind regards,
Evert Vorster

On 17 October 2014 14:46, Karl Kiniger <karl.kiniger at med.ge.com> wrote:
> Please.
>
> Reason: in my workflow with AV tracks audio fades I need fade from/to black very
>         rarely. However on many simple edit tasks which dont justify splitting A/V
>         into V and A  audio fades are often necessary to avoid noticeable glitches.
>
> Thank you very much writing/improving/maintaining kdenlive,
>
> Karl
>
> diff --git a/src/timeline/customtrackview.cpp b/src/timeline/customtrackview.cpp
> index 58ae93a..6356e0e 100644
> --- a/src/timeline/customtrackview.cpp
> +++ b/src/timeline/customtrackview.cpp
> @@ -4100,7 +4100,7 @@ void CustomTrackView::mouseReleaseEvent(QMouseEvent * event)
>          // new fade in
>          } else if (item->fadeIn() != 0) {
>              QDomElement effect;
> -            if (item->isVideoOnly() || (item->clipType() != Audio && !item->isAudioOnly() && item->clipType() != Playlist)) {
> +            if (item->isVideoOnly() || (((item->clipType() != Audio) && (item->clipType()) != AV && (item->clipType() != Playlist)))) {
>                  effect = MainWindow::videoEffects.getEffectByTag("", "fade_from_black").cloneNode().toElement();
>              } else {
>                  effect = MainWindow::audioEffects.getEffectByTag("volume", "fadein").cloneNode().toElement();
> @@ -4133,7 +4133,7 @@ void CustomTrackView::mouseReleaseEvent(QMouseEvent * event)
>          // new fade out
>          } else if (item->fadeOut() != 0) {
>              QDomElement effect;
> -            if (item->isVideoOnly() || (item->clipType() != Audio && !item->isAudioOnly() && item->clipType() != Playlist)) {
> +            if (item->isVideoOnly() || (((item->clipType() != Audio) && (item->clipType()) != AV && (item->clipType() != Playlist)))) {
>                  effect = MainWindow::videoEffects.getEffectByTag("", "fade_to_black").cloneNode().toElement();
>              } else {
>                  effect = MainWindow::audioEffects.getEffectByTag("volume", "fadeout").cloneNode().toElement();
>
>
>
>
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> Kdenlive-devel mailing list
> Kdenlive-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kdenlive-devel



-- 
Evert Vorster
Chief Observer
WG Cook